-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Modernize] Update project to use modern gradle practices #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was also incredibly complicated for what should be simple using modern Gradle patterns. This modernizes the patterns to use kotlin as that is the recommendedway to write gradle plugins today.
…set specific *only* This removes the complicated "global" options in favour of a simpler "source-set" specific set of options intead. This was extracted as part of a refactor to update this project to use modern gradle paradigms. Extracted from #29.
Nava2
commented
Apr 21, 2023
* Source Set implementation used to allow definition within the JavaPlugin's | ||
* Source sets. This does not extend [SourceSet]. | ||
*/ | ||
interface AssertJGeneratorSourceSet { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
#30) * [Simplification] Remove global options in plugin in favour of source-set specific *only* This removes the complicated "global" options in favour of a simpler "source-set" specific set of options intead. This was extracted as part of a refactor to update this project to use modern gradle paradigms. Extracted from #29. * update README.md to reflect removal of global settings
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
…are for konvert Extracted from #29
This was referenced Apr 23, 2023
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This adds unidirectional Kotlin support for writing code in Kotlin and using it in Groovy. Extracted from #29
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This adds unidirectional Kotlin support for writing code in Kotlin and using it in Groovy. Extracted from #29
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This has some small clean-ups before running Konvert on the EntryPointOptions type. Extracted from #29
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This has some small clean-ups before running Konvert on the EntryPointOptions type. Extracted from #29
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This has some small clean-ups before running Konvert on the EntryPointOptions type. Extracted from #29
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This is a straight conversion with no functionality changes. Extracted from #29.
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This is a straight conversion with no functionality changes. Extracted from #29.
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This is a straight conversion with no functionality changes. Extracted from #29.
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This is a straight conversion to Kotlin with no behaviour changes. Extracted from #29.
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This is a straight conversion with no functionality changes. Extracted from #29.
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This is a straight conversion to Kotlin with no behaviour changes. Extracted from #29.
Nava2
added a commit
that referenced
this pull request
Apr 23, 2023
This is a straight conversion to Kotlin with no behaviour changes. Extracted from #29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP and many small ones should be extracted from it
Related to #17, this PR updates the code base in the following ways:
JavaPluginConvention
java
plugin #34ListProperty<>
values for `Te… #32SourceSet
in favour ofextension
attached tosourceSet
which is easier and more common "gradle-like"AssertJOptions
into a single classDefaultAssertJGeneratorOptions
into single class #31Either<>
type and use simpler propertiesEither
custom type inTemplates
infavour of simpler type #38Report
code paths to useself
extensions in groovy (makes kotlin more obvious)